Attempt to fix kotlin 2.2 issue #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
7 tasks
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Attempt to fix kotlin 2.2 issue ([#4603](https://github.com/getsentry/sentry-java/pull/4603))If none of the above apply, you can opt out of this check by adding |
adinauer
force-pushed
the
08-04-fix_spring_7_and_spring_boot_4_modules
branch
from
c7988b5 to
a5d68ca
Compare
adinauer
force-pushed
the
08-04-attempt_to_fix_kotlin_2.2_issue
branch
from
91df7de to
c97638e
Compare
7 tasks
adinauer
force-pushed
the
08-04-fix_spring_7_and_spring_boot_4_modules
branch
from
a5d68ca to
7887992
Compare
adinauer
force-pushed
the
08-04-attempt_to_fix_kotlin_2.2_issue
branch
from
c97638e to
68a8b1d
Compare
This was referenced Aug 7, 2025
* Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat (#4613) --------- Co-authored-by: Sentry Github Bot <[email protected]>
Base automatically changed from
08-04-fix_spring_7_and_spring_boot_4_modules
to
08-04-add_new_modules_for_spring_7_and_spring_boot_4
August 8, 2025 10:02
…nto 08-04-attempt_to_fix_kotlin_2.2_issue
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0fef848 | 426.67 ms | 455.08 ms | 28.41 ms |
| e7c4664 | 416.04 ms | 441.27 ms | 25.22 ms |
| b2c2d0b | 414.00 ms | 447.42 ms | 33.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0fef848 | 1.58 MiB | 2.09 MiB | 522.33 KiB |
| e7c4664 | 1.58 MiB | 2.09 MiB | 521.83 KiB |
| b2c2d0b | 1.58 MiB | 2.09 MiB | 521.57 KiB |
* Second attempt to fix Kotlin 2.2 * Format code * Third attempt at fixing Kotlin 2.2 compat * Fix tests for Spring 7 and Spring Boot 4 * Move Spring 7 and Spring Boot 4 packages (#4615) * Move Spring 7 and Spring Boot 4 packages * Fix class not found due to OTel not supporting spring boot 4 yet (#4616) * Format code * some fixes * change kotlin 1.8 to 1.9 and some cleanup * ignore warnings about api level that is not relevant * fix optional dependencies in SentryAutoConfiguration * Update trace origin * Remove duplicate e2e test config * Update Strings for Spring 7 and Spring Boot 4 * Disable Spring Boot 4 agentless e2e tests for now --------- Co-authored-by: Sentry Github Bot <[email protected]>
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
adinauer
merged commit 59cb440
into
08-04-add_new_modules_for_spring_7_and_spring_boot_4
30 of 33 checks passed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @Bean | ||
| public SentrySpanWebClientCustomizer sentrySpanWebClientCustomizer(IScopes scopes) { | ||
| return new SentrySpanWebClientCustomizer(scopes); | ||
| } |
There was a problem hiding this comment.
Bug: Sentry Customizers Fail Due to Incorrect Class Checks
Auto-configuration wrappers for RestTemplate, RestClient, and WebClient incorrectly use @ConditionalOnClass to require their respective *AutoConfiguration classes. This prevents Sentry customizers from registering if the auto-configuration class is missing or relocated, even when the client is present. This silently disables span instrumentation for these clients in Spring Boot 4. The wrapper's @ConditionalOnClass should only check for the client, relying on the inner configuration's @AutoConfigureBefore for ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps